Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should 'latest' be given it's own input as a 'boolen'? #19

Closed
LongLiveCHIEF opened this issue Nov 26, 2020 · 3 comments · Fixed by #23
Closed

Should 'latest' be given it's own input as a 'boolen'? #19

LongLiveCHIEF opened this issue Nov 26, 2020 · 3 comments · Fixed by #23

Comments

@LongLiveCHIEF
Copy link

The generation of latest seems somewhat problematic. There no way to directly prevent latest from being generated in many cases,

Would it be better, easier, and more straightforware to remove the latest generation logic entirely the way it is now, and just make it a boolean input type so that users could specify whether or not to generate the latest explicitly regardless of the event?
@LongLiveCHIEF
Copy link
Author

Actually, i'm starting to wonder why it wouldn't just be better if the user passed in the appropriate context all together instead of trying to determine the context based on the event type.

@LongLiveCHIEF LongLiveCHIEF mentioned this issue Nov 26, 2020
Closed
@LongLiveCHIEF
Copy link
Author

related comment #18 (comment)

@crazy-max crazy-max mentioned this issue Dec 1, 2020
Merged
@crazy-max
Copy link
Member

@LongLiveCHIEF #23 should fix your issue (new input called tag-latest).
Can be tested with uses: crazy-max/ghaction-docker-meta:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to disable latest tag docker/metadata-action
2 participants
@crazy-max @LongLiveCHIEF