Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tag-semver work without patch version? #20

Closed
EnricoMi opened this issue Nov 30, 2020 · 1 comment · Fixed by #22
Closed

Should tag-semver work without patch version? #20

EnricoMi opened this issue Nov 30, 2020 · 1 comment · Fixed by #22

Comments

@EnricoMi
Copy link

Some small projects might decide not to release patch versions but still follow the semantic versioning rules. Can this action work with tag-semver: v${{major}} on tags like v1.0 to produce v1? Currently, it does not seem to:

https://github.com/EnricoMi/publish-unit-test-result-action/runs/1474478085?check_suite_focus=true

Run crazy-max/ghaction-docker-meta@v1
  with:
    images: ghcr.io/EnricoMi/publish-unit-test-result-action
    tag-sha: true
    tag-semver: {{raw}}
  v{{major}}.{{minor}}
  v{{major}}
  
    tag-edge: false
    tag-match-group: 0
    tag-match-latest: true
    tag-schedule: nightly
    github-token: ***
Context info
Docker image version
  v1.6
Docker tags
  ghcr.io/enricomi/publish-unit-test-result-action:v1.6
  ghcr.io/enricomi/publish-unit-test-result-action:latest
  ghcr.io/enricomi/publish-unit-test-result-action:sha-f1387c5
@crazy-max
Copy link
Member

crazy-max commented Dec 1, 2020

@EnricoMi

Currently, it does not seem to

That's because v1.6 tag is not a valid semver:

  1. A normal version number MUST take the form X.Y.Z where X, Y, and Z are non-negative integers, and MUST NOT contain leading zeroes. X is the major version, Y is the minor version, and Z is the patch version. Each element MUST increase numerically. For instance: 1.9.0 -> 1.10.0 -> 1.11.0.

Should have been v1.6.0 to be a valid one for example. I will add a warning message in case tag-semver is used but input tag is not a valid semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants