Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and pin mattes/migrate to the v3.0.0 tag #1151

Merged
merged 3 commits into from
May 8, 2017

Conversation

ashfall
Copy link
Contributor

@ashfall ashfall commented May 8, 2017

Signed-off-by: Ashwini Oruganti ashwini.oruganti@gmail.com

Signed-off-by: Ashwini Oruganti <ashwini.oruganti@gmail.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "upgrade-migrate" git@github.com:ashfall/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354133312
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
Signed-off-by: Ashwini Oruganti <ashwini.oruganti@gmail.com>
Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyli
Copy link
Contributor

cyli commented May 8, 2017

LGTM! Thanks for fixing this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants