Ensure that we do not clobber in-memory key id data on delegation list #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on list Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
riyazdf
changed the title
riyazdf
changed the title
|
I personally tried this and it works as expected, thanks for the quick fixing! |
|
@HuKeping thank you for trying this out 👍 |
|
Great catch! Thanks for fixing this so fast, and for the test! Non-blocking, but would it make sense to add a moe specific unit test for Otherwise LGTM! |
riyazdf
changed the title
|
Pre-expansion patch live now :) @cyli |
riyazdf
force-pushed
the
fix-deep-delegation-listing
branch
from
f76839c
to
b828631
Compare
when listing and converting to canonical ID Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
|
@cyli: great idea, added on to a delegation publishing test |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought up by @HuKeping in #852 (comment), I noticed that
translateDelegationsToCanonicalIDswas mistakenly editing in-memory metadata by replacing TUF key IDs with canonical key IDs, which would cause nested delegations to have issues when building intodata.DelegationRolestructs.Changed pass-by-reference to pass-by-value and added a test that publishes a nested delegation and ensures that
delegation listbehaves as expected.