-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
@nigelpoulton Here are the WIP docs; I've split them and just making the language conform for clarity. Typical to our docs, we often say Docker to mean "Docker Engine" but our readers can't see the difference and it just sounds like are repeating "Docker, Docker, Docker" with several products that start with this name, we should use the specific product when we mean one. That's where most of my changes are... |
0696fc0
to
6452e14
Compare
@nigelpoulton @mgoelzer @amitshukla Gents, this is ready for review. @nigelpoulton I incorporated Mike's comments and made some sentence structural changes to make the read an easier ride. I don't think I foobared the technical. One thing to note, in some places you had readers elevating to |
@moxiegirl Good idea re |
@nigelpoulton OK, cool. I'll remove the elevate steps and just use |
>`Note`:If you already have access to a CA and certificates, and are comfortable working with them, you should skip this step and go to the next. | ||
|
||
In this step, you configure a Linux server as a CA. You use this CA to create | ||
and sign keys. This step included so that readers without access to an existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add is
to become This step *is* included
I like the step7 process of creating a customized version of the swarm image. Creative and avoids using volumes. Nice pictures throughout. I like the Passport analogy. Looking good so far. |
|
||
|
||
# Planning for Swarm in production | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I have time I will make the examples more generic and not AWS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which examples? I didn't see any mention of AWS in this piece. Oh wait, you mention Azure and AWS at the same time...that can be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moxiegirl All of the HA examples refer to AWS availability zones as do the diagrams. I'm happy to leave it that way (it's easier). But there was a convo on slack yesterday about referencing AWS too much might look like we're taking sides. Any thoughts?
@nigelpoulton @mgoelzer @amitshukla @rolfedh This PR contains the latest content from Nigel that incorporates everyone's comments. Moving forward, please comment against this rather than the email thread. It simply is easier to track and check off comments here rather than juggling emails. As we get closer to the release, efficiency is crticial. |
Understood. Thanks, @moxiegirl On Fri, Jan 29, 2016 at 10:31 AM, moxiegirl notifications@github.com
Mike Goelzer |
@mgoelzer @amitshukla @vieux @abronan @aluzzardi Can I get a review of this. Nigel is pretty much out the door because he has family obligations. I want to get comments and enter them by EOD Monday. Lots of moving parts on 1.10. |
571e369
to
a177574
Compare
For more information on configuring Swarm for TLS, see the **need link to | ||
securing swarm article** | ||
|
||
### Network access control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also mention the ports for libnetwork if used with swarm?
So:
- tcp 7946 (serf gossip)
- udp 7946 (serf gossip)
- tcp
<store-port>
(depends on the distributed kv store used) - udp 4789 (vxlan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I think we should whack a sentence before it though explaining that if you are using container networking then these re the ports....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nigelpoulton Yes sounds good to me to first mention it and explain the specifics with ports if libnetwork is used 👍
Struct edit pass thru conceptual material Updating with comments from Mike Tweaking menu layout Updating for Nigel Updating with local images, formatting fixes Updating with the comments from review Signed-off-by: Mary Anthony <mary@docker.com>
0df2914
to
f93d787
Compare
@abronan @mgoelzer Hi gents, can I get the final review and hopefully, LGTMs. |
|
||
## Related information | ||
|
||
The application in this example could be deployed on Docker Universal Control Plane (UPC) which is currently in Beta release. To try the application on UPC in your environment, [request access to the UPC Beta release](https://www.docker.com/products/docker-universal-control-plane). Other useful documentation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPC -> UCP?
Signed-off-by: Mary Anthony <mary@docker.com>
LGTM |
1 similar comment
LGTM |
High-level docs for Swarm
Signed-off-by: Mary Anthony mary@docker.com