This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swarm /events API may be will stop immediately at sometime.
After digging these codes I found that we should be carefully to stop a timer. A timer maybe has already expired, even the duration is zero.
We can write an example to prove it:
Save as
timerTest.go
andgo run
with it:So we have to check the
timer.Stop
return value and drain the channel manually.Signed-off-by: realityone realityone@me.com