Explicitly disallow network pluginv1 creation in swarm mode. #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In swarm mode, only network pluginv2 is supported; pluginv1 is not. When the plugin support was re-enabled, it inadvertently allowed both pluginv1 and pluginv2. This commit fixes that. Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
|
Adding reference to #1894 to capture all the discussions and reasoning that went behind this change. @anusha-ragunathan thanks for the additional change to check for the builtIn drivers. The better fix would be to check for the newly introduced libnetwork's LGTM |
|
LGTM |
1 similar comment
|
LGTM |
aaronlehmann
added
process/cherry-pick
process/cherry-picked
and removed
process/cherry-pick
labels
yongtang
added a commit
to yongtang/docker
that referenced
this pull request
Jan 29, 2017
This fix updates SwarmKit to 78ae345 (from 037b491) The following issues in docker are related - Can not update service in host publish mode (moby#30199) (fixed) - Add `ReadonlyRootfs` in ContainerSpec for `--read-only` (moby#29972) (needed) - Explicitly disallow network pluginv1 creation in swarm mode (See discussion in moby/swarmkit/pull/1899, moby/swarmkit/pull/1894, and moby/pull/30332#issuecomment-274277948) This fix fixes moby#30199 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This was referenced Jan 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In swarm mode, only network pluginv2 is supported; pluginv1 is not.
When the plugin support was re-enabled, it inadvertently allowed
both pluginv1 and pluginv2. This commit fixes that.
Signed-off-by: Anusha Ragunathan anusha.ragunathan@docker.com