Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First part of if condition redundant #2

Closed
EDGDrummond opened this issue Feb 8, 2022 · 1 comment
Closed

First part of if condition redundant #2

EDGDrummond opened this issue Feb 8, 2022 · 1 comment

Comments

@EDGDrummond
Copy link

EDGDrummond commented Feb 8, 2022 •
edited
Loading

crypto/compressed_sigma/src/amortized_homomorphism.rs

Line 79 in 2eee4a6

if witnesses.len() > j && witnesses[j].len() > i {

We check if witnesses.len() > j, but j < witnesses.len() by definition so this is trivially true.
@esplinr
Copy link

esplinr commented May 16, 2024

We made the change requested. Thank you for the report!

@esplinr esplinr closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esplinr @EDGDrummond