Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo check in the CI and make it fail if cargo check fails #22

Open
lovesh opened this issue Apr 1, 2020 · 2 comments
Open

Add cargo check in the CI and make it fail if cargo check fails #22

lovesh opened this issue Apr 1, 2020 · 2 comments

Comments

@lovesh
Copy link
Member

lovesh commented Apr 1, 2020

No description provided.

@lovesh lovesh changed the title Add cargo check in the CI Add cargo check in the CI and make it fail if cargo check fails Apr 1, 2020
@bddap
Copy link
Contributor

bddap commented Apr 1, 2020

cargo-build already performs all the same checks as cargo-check so this wouldn't do anything by itself. cargo-check does a subset of what cargo build does.

cargo-clippy could be useful but it currently fails due wasm build trickery.

If we want to fail CI when there are warnings, cargo rustc -- -Dwarnings would work. We could also use RUSTFLAGS="-D warnings" cargo build as mentioned in https://github.com/rust-unofficial/patterns/blob/master/anti_patterns/deny-warnings.md .

@bddap
Copy link
Contributor

bddap commented Jun 2, 2020

We can add RUSTFLAGS="-D warnings" to our unit tests if we want CI to fail on warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants