Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with multiple docker-compose files based app #47

Closed
ryuheechul opened this issue Jul 25, 2017 · 9 comments
Closed

Doesn't work with multiple docker-compose files based app #47

ryuheechul opened this issue Jul 25, 2017 · 9 comments
Assignees
Projects
Milestone

Comments

@ryuheechul
Copy link

screen shot 2017-07-25 at 11 38 10 am

There are docker-compose.override.yml exist.
So it should work with dockstation, since it works well with commands

@igor-lemon
Copy link
Member

igor-lemon commented Jul 25, 2017

Hi @ryuheechul. We'll add a possibility to work with override compose configs in the next release.

@igor-lemon igor-lemon assigned igor-lemon and pashist and unassigned igor-lemon Jul 25, 2017
@igor-lemon igor-lemon added this to the v1.3.0 milestone Jul 25, 2017
@igor-lemon igor-lemon self-assigned this Jul 25, 2017
@igor-lemon igor-lemon added this to To Do in DockStation Aug 3, 2017
@igor-lemon igor-lemon moved this from To Do to In Progress in DockStation Aug 4, 2017
@igor-lemon
Copy link
Member

Released into v1.3

@igor-lemon igor-lemon moved this from In Progress to Close in DockStation Sep 6, 2017
@moonion
Copy link

moonion commented Sep 21, 2017

It doesn't work for me :(
When I create new project and select paths where exist docker-compose.yml and docker-compose.override.yml. Because my project can't be run without docker-compose.override.yml.

MacOS.
screen

@igor-lemon
Copy link
Member

Hi @moonion
Can you share your docker-compose.yml and docker-compose.override.yml configs ?
Also thanks for a bug with button layers...

@igor-lemon
Copy link
Member

Also call docker-compose config command into the directory with your configs and share screenshot. Thank you.

@moonion
Copy link

moonion commented Sep 21, 2017

hi @igor-lemon
I replaced /.../ and registry/

docker-compose.yml

version: '2'
services:
  app:
  backend:
    links:
      - db
    environment:
      - DB_DATABASE=test
      - DB_HOST=db
      - DB_USERNAME=test
      - DB_PASSWORD=test
    volumes:
      - './data/uploads/images:/var/www/html/uploads/images'
      - './data/uploads/staff/images:/var/www/html/uploads/staff/images'
      - './data/uploads/videos:/var/www/html/uploads/videos'
  db:
    image: mariadb
    environment:
      - MYSQL_DATABASE=test
      - MYSQL_USER=test
      - MYSQL_PASSWORD=test
      - MYSQL_ROOT_PASSWORD=test
    volumes:
      - './data/mysql:/var/lib/mysql'
  nginx:
    image: registry/docker/nginx
    depends_on:
      - app
      - backend
    volumes_from:
      - 'app:ro'
      - 'backend:ro'

docker-compose.override.yml

version: "2"
services:
  app:
    build:
      context: ../app
      dockerfile: Dockerfile.local
    volumes:
      - ../app/src:/usr/src/src
  backend:
     image: registry/test/backend
  nginx:
    ports:
      - "80:80"

docker-compose config

services:
  app:
    build:
      context: /.../test/app
      dockerfile: Dockerfile.local
    volumes:
    - /.../test/app/src:/usr/src/src:rw
  backend:
    environment:
      DB_DATABASE: test
      DB_HOST: db
      DB_PASSWORD: test
      DB_USERNAME: test
    image: registry/test/backend
    links:
    - db
    volumes:
    - /.../data/uploads/images:/var/www/html/uploads/images:rw
    - /.../data/uploads/staff/images:/var/www/html/uploads/staff/images:rw
    - /.../data/uploads/videos:/var/www/html/uploads/videos:rw
  db:
    environment:
      MYSQL_DATABASE: test
      MYSQL_PASSWORD: test
      MYSQL_ROOT_PASSWORD: test
      MYSQL_USER: test
    image: mariadb
    volumes:
    - /.../data/mysql:/var/lib/mysql:rw
  nginx:
    depends_on:
    - app
    - backend
    image: registry/docker/nginx
    ports:
    - 80:80/tcp
    volumes_from:
    - service:app:ro
    - service:backend:ro
version: '2.0'

@igor-lemon
Copy link
Member

@moonion So, are you sure that didn't forget to add override configs into project settings?
image

@igor-lemon
Copy link
Member

igor-lemon commented Sep 21, 2017

Oh, sorry. You can't add override while your first file docker-compose not correct.
Your app service isn't correct in the first config. You can try to assign build or image option to app service for making the docker-compose.yml file correctly. After that, you can add override configs from settings of the project.

Later we'll add possibility to assign override configs during adding a project.

@moonion
Copy link

moonion commented Sep 22, 2017

@igor-lemon thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants