Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating DOIs for tool versions not working/weird on swagger #2785

Closed
NatalieEO opened this issue Aug 21, 2019 · 2 comments
Closed

Creating DOIs for tool versions not working/weird on swagger #2785

NatalieEO opened this issue Aug 21, 2019 · 2 comments
Assignees
Labels
bug review merged but pending a third party look at whether it makes sense/is working
Milestone

Comments

@NatalieEO
Copy link
Contributor

NatalieEO commented Aug 21, 2019

Bug Report

Expected behaviour

If you try to create a DOI for a tool version, it should either fail and give an appropriate error of some kind, or be successful and actually create the DOI.

Actual behaviour

When trying to create a DOI for a tool version (not frozen) that's yours, you get a response that looks successful.
image
But no DOI is actually created. You can keep requesting it for the same one and get the same response above.
It does fail appropriately if it doesn't belong to you or it can't find the tool.

Steps to reproduce the behaviour

Go to https://staging.dockstore.org/api/static/swagger-ui/index.html#/containertags/requestDOIForToolTag
Try to create a DOI for some tool version

┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 1.7.x
┆Issue Number: DOCK-922
┆Sprint: Seabright Sprint 18 Skipjack
┆Issue Type: Story

@NatalieEO NatalieEO added the bug label Aug 21, 2019
@denis-yuen denis-yuen added this to the 1.7.x milestone Aug 22, 2019
@denis-yuen
Copy link
Member

Note to self: not-actually implementing for 1.7, but should leave a clear path for 1.8

@denis-yuen denis-yuen added the review merged but pending a third party look at whether it makes sense/is working label Sep 11, 2019
@denis-yuen denis-yuen modified the milestones: 1.7.x, 1.7.0 Sep 11, 2019
@cricketsloan
Copy link

➤ Charles Overbeck commented:

Verified on staging that trying to create a DOI for tools returns a 400 status code with the message “DOI creation for tools has not been implemented yet.”

API version: 1.7.0-rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review merged but pending a third party look at whether it makes sense/is working
Projects
None yet
Development

No branches or pull requests

3 participants