Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in github apps wizard #3848

Closed
denis-yuen opened this issue Oct 6, 2020 · 4 comments
Closed

Broken link in github apps wizard #3848

denis-yuen opened this issue Oct 6, 2020 · 4 comments
Assignees
@GFJHogue
Labels
bug gui Issues related to the current GUI.

Comments

@denis-yuen
Copy link
Member

denis-yuen commented Oct 6, 2020 •
edited by unito-bot

Describe the bug
Broken link in ui2 wizard page
Reproduced in dev and prod
Also see https://discuss.dockstore.org/t/broken-link-in-register-using-github-apps-instructions/3896

Thanks @mr-c ! for the heads-up

┆Issue is synchronized with this Jira Story
┆Issue Number: DOCK-1602
┆Sprint: Sprint 46- Unicorn Fish
┆Issue Type: Story
@denis-yuen denis-yuen added bug gui Issues related to the current GUI. labels Oct 6, 2020
@denis-yuen denis-yuen changed the title Broken link Broken link in github apps wizard Oct 6, 2020
@denis-yuen
Copy link
Member Author

Also bumping #3793

@GFJHogue GFJHogue assigned GFJHogue and unassigned garyluu Oct 22, 2020
@GFJHogue
Copy link
Contributor

Already done by @denis-yuen in hotfix 2.7.2 - works on staging :)
dockstore/dockstore-ui2#1075

@GFJHogue
Copy link
Contributor

Confirmed also working on dev.
Likely we forgot the change was made to hotfix/2.7.2 and then assumed it wasn't done, because it wasn't on dev until we merged the hotfix back into develop.

@denis-yuen
Copy link
Member Author

Oh, whoops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GFJHogue GFJHogue

Labels
bug gui Issues related to the current GUI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@denis-yuen @GFJHogue @garyluu