Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't manipulate the .env file #165

Open
shyim opened this issue Mar 21, 2023 · 7 comments
Open

Don't manipulate the .env file #165

shyim opened this issue Mar 21, 2023 · 7 comments
Assignees

Comments

@shyim
Copy link

shyim commented Mar 21, 2023

Describe the bug
Dockware should always create a .env.local file instead modifying the existing .env file.

To Reproduce
Try to update Shopware with the new updater

Expected behavior
Dockware creates a .env.local instead modiying the existing .env

@sandoba
Copy link

sandoba commented May 8, 2023

I'd support this as well. Best to have a separate ".env.local" file with e.g. "APP_URL=dev" and "DATABASE_URL=..." as this file is blocked from Git via .gitignore.

@martinweinmayr martinweinmayr self-assigned this May 9, 2023
@martinweinmayr
Copy link
Collaborator

will come for all images 6.5 and newer with our dockware 2.0 version this week

@shyim shyim closed this as completed Dec 22, 2023
@jkobus
Copy link

jkobus commented Jan 30, 2024

Using dockware/dev:6.5.8.2 and it seems that there is no .env.local there.

@shyim
Copy link
Author

shyim commented Apr 2, 2024

yup seems still broken

@shyim shyim reopened this Apr 2, 2024
@openmindculture
Copy link

dockware/dev:6.0.0.1 has the same problem which crashes the system when using the updater in admin

@boxblinkracer
Copy link
Collaborator

hi
so the reason why theres no .env.local is because we have 3 layers
- showpare
- dockware
- custom shop project

we are doing a few things in the prepared .env, like using 127.0.0.1 for DB instead of localhost (required somehow, but just as an example)
if we would use a .env.local, then its very likely that the .env.local of the project might not have that setting
which means its automatically broken, because all our settings will be immedately overwritten by the project that uses dockware

thats the reason why we are adjusting the .env instead of the .env.local

the question with the admin-updater is something else right? is there anything in the .env which is the reason why its broken? thought its a shopware problem?
i think we are just using the original .env and changing a few values

@shyim
Copy link
Author

shyim commented Apr 2, 2024

The alternative solution would be that you disable the auto updater with yaml config 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants