Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch-admin not working in dockware/contribute image #9

Closed
jniclas opened this issue Aug 11, 2020 · 3 comments
Closed

watch-admin not working in dockware/contribute image #9

jniclas opened this issue Aug 11, 2020 · 3 comments

Comments

@jniclas
Copy link

jniclas commented Aug 11, 2020

If I try to run
make watch-admin
I get

BaseUrl for proxy is set to "undefined"

 ⚠️  You need to add the "APP_URL" as an environment variable for compiling the code. ⚠️

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! administration@1.0.0 dev: `mode=development webpack-dev-server "http://0.0.0.0"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the administration@1.0.0 dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /var/www/.npm/_logs/2020-08-11T07_30_19_654Z-debug.log
makefile:19: recipe for target 'watch-admin' failed
make: *** [watch-admin] Error 1

Container runs with docker-compose:

sw:
        image: dockware/contribute
        container_name: sw
        ports:
            - "80:80"
            - "22:22"
            # Admin Watcher Port
            - "8888:8888"
            # Storefront Watcher Port
            - "9999:9999"
        environment:
            - PHP_VERSION=7.4
            - XDEBUG_ENABLED=1
            - SW_CURRENCY=EUR
            - PHP_IDE_CONFIG=serverName=PHPStorm

Same thing works great with dockware/dev:6.1.5

@boxblinkracer
Copy link
Collaborator

hi

thank you for sharing your issue

i did recently change the contribute version to use the psh watcher.
because for contribution the psh is still required

i just saw it hasn't been pushed yet

but can you try to use the psh watcher?

thanks

@jniclas jniclas changed the title wat-admin not working in dockware/contribute image watch-admin not working in dockware/contribute image Aug 11, 2020
@jniclas
Copy link
Author

jniclas commented Aug 14, 2020

Hey,

thank you for your support. The psh watcher works fine.

@jniclas jniclas closed this as completed Aug 14, 2020
@boxblinkracer
Copy link
Collaborator

Hi
awesome ,
thanks for your feedback

i've just pushed the new contribute image, that wraps the psh watchers in our watcher :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants