Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save_and_open is using body as filename #15

Closed
tylerhunt opened this issue Dec 31, 2012 · 4 comments
Closed

save_and_open is using body as filename #15

tylerhunt opened this issue Dec 31, 2012 · 4 comments
Labels
bug

Comments

@tylerhunt
Copy link

Capybara::Session#save_and_open_page takes a file name argument, but Capybara::Node::Email#save_and_open is passing it the body instead. This results in directories and files being created with the content of the email, like so:

$> ls -l tmp/capybara/
total 0
drwxr-xr-x  3 thunt  staff  102 Dec 31 14:17 <!DOCTYPE html>??<html>??  <head>??    <meta content="text

The resulting file is empty.
@bcardarella
Copy link
Contributor

@tylerhunt what version of Capybara are you using?

@bcardarella
Copy link
Contributor

actually this looks like a Capybara 2.0 issue. Confirmed, I should have a fix in about 30 minute or so. Sorry it took a few days to get to

@bcardarella
Copy link
Contributor

@tylerhunt try out master branch and let me know.

Capybara itself doesn't have any tests for this so I wasn't sure myself how best to test it.

@tylerhunt
Copy link
Author

Works great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tylerhunt @bcardarella