Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_unbindListeners() should clear the instance of the event listeners per element #1

Closed
poteto opened this issue Apr 16, 2015 · 0 comments

Comments

@poteto
Copy link
Collaborator

poteto commented Apr 16, 2015

This method clears all event listeners on the window and document (in reality, this mixin has only 3 listeners regardless of the number of Components, because of the way Ember registers event listeners globally), which means if you have >1 Component to watch, after one enters the viewport, it unbinds listeners for all other Components, whether or not they have entered the viewport.

@poteto poteto closed this as completed in #3 Apr 16, 2015
mattsgarrison added a commit to mattsgarrison/ember-in-viewport that referenced this issue Oct 24, 2017
Commiting changes from the PR proposal to unify rAF to a service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant