New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP port, all tests pass #26
Comments
That is very impressive! Would you like to join |
That sounds great! Thanks halst. Are there any requirements? Is there anything I need to do to the PHP lib, or avoid doing with it? |
Oh also, I forgot to mention in the initial post - how would you like me to license the work and how would you like me to attribute you? |
No special requirements—the fact that tests pass is good enough. We'll see if there could be any improvements. Licence and attribution: It's 100% your work, so you can license it as you want. The idea of docopt language is unoriginal, so I have no claims :-) However, I suggest to use MIT license—same as other docopt implementations. |
Awesome, MIT it is! How do I add the repo to the docopt team? Should I use "Fork to docopt" from the fork dialog or is there another way? |
Try going to your repo's Admin-page -> Danger Zone -> Transfer Ownership and set |
I got a little spooked by the severity of the dialog so tried the fork option first, but it made "forked from shabbyrobe/docopt.php" appear up the top so I killed that off, summoned some bravery and did the transfer. Needless to say, it worked perfectly. I'll have to update the http://packagist.org/ setup, which is currently still pointing to shabbyrobe/docopt. |
Hmm, I think I might have done something wrong - I don't have write access to docopt/docopt.php any more. I've got write access to everything else, just not the PHP one. |
I think I fixed that, do you have write access now? |
Yep, it's all good now. Cheers |
Hey what should I do about the packagist repo? It's currently under shabbyrobe/docopt. Should I register docopt on there and move it to docopt/docopt? |
I don't know how packagist works exactly. (In case of PyPI you just upload code and it doesn't link to any repo). I guess the best is to associate the repo that you think will be most up-to-date? |
I close this, further PHP-discussion is done on: https://github.com/docopt/docopt.php/issues |
You know when you see something that you don't know how you ever lived without... We do mostly PHP where I work so rather than keep living without docopt I whipped up a quick and dirty transliteration.
It passes all of the tests in the language_agnostic_parser, but it hasn't really been given much of a workout yet and there could be some issues I haven't found.
https://github.com/shabbyrobe/docopt.php
The main issue at the moment is that DocoptExit doesn't quite work in PHP like it should - SystemExit has no obvious analog in PHP so it currently requires a catch block, but I'm working on that.
Thanks again for such a fantastic library, and a very, very big thanks for the language agnostic tester.
The text was updated successfully, but these errors were encountered: