Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin tests fail when finishing up #1047

Closed
SteveMcArthur opened this issue Jun 26, 2016 · 11 comments
Closed

Plugin tests fail when finishing up #1047

SteveMcArthur opened this issue Jun 26, 2016 · 11 comments

Comments

@SteveMcArthur
Copy link
Contributor

All of a sudden when I run a plugin test the test will fail massively with a never-ending, repeating stacktrace AFTER all test have completed successfully when the "finishing up" message shows. It seems to occur after installing the node_modules for a plugin. I first noticed it on travis, even though everything ran fine locally. Once I had deleted the node_modules directory and run npm install (or cake install) I would then get the error. I've downloaded the eco plugin and get the same results. Travis builds fail on node 0.12 and 4.4. I thought it may have been changes to the way NPM installs dependencies so downgraded from 3.8.8 to 2.15.5

It's hard to pinpoint where exactly the error is. The stacktrace comes from taskgroup - but that doesn't really seem to help. Can anyone else duplicate this problem?

@SteveMcArthur
Copy link
Contributor Author

SteveMcArthur commented Jun 26, 2016

Stacktrace:

Error: The task [destroy] just completed, but it had already completed earlier, this is unexpected. State information is:
{ error: 'Error: write after end\n  at writeAfterEnd (_stream_writable.js:166:12)\n  at Logger.Writable.write (_stream_writable.js:211:5)\n
  at Logger.log (F:\\Development\\docpad\\docpad-plugin-eco\\node_modules\\docpad\\node_modules\\caterpillar\\out\\lib\\caterpillar.js:225:12)\n
  at Logger.__bind [as log] (F:\\Development\\docpad\\docpad-plugin-eco\\node_modules\\docpad\\node_modules\\caterpillar\\out\\lib\\caterpillar.js:4:61)\n
  at DocPad.log (F:\\Development\\docpad\\docpad-plugin-eco\\node_modules\\docpad\\out\\lib\\docpad.js:3372:16)\n
  at _Class.<anonymous> (F:\\Development\\docpad\\docpad-plugin-eco\\node_modules\\docpad\\out\\lib\\docpad.js:1968:27)\n
  at emitTwo (events.js:87:13)\n  at _Class.emit (events.js:172:7)\n  at Task.<anonymous> (F:\\Development\\docpad\\docpad-plugin-eco\\node_modules\\docpad\\node_modules\\taskgroup\\out\\lib\\taskgroup.js:753:26)\n
  at emitOne (events.js:82:20)\n  at Task.emit (events.js:169:7)\n  at Task.<anonymous> (F:\\Development\\docpad\\docpad-plugin-eco\\node_modules\\docpad\\node_modules\\taskgroup\\out\\lib\\taskgroup.js:53:28)\n
  at emitOne (events.js:82:20)\n
  at Task.emit (events.js:169:7)\n
  at Task.complete (F:\\Development\\docpad\\docpad-plugin-eco\\node_modules\\docpad\\node_modules\\taskgroup\\out\\lib\\taskgroup.js:319:19)\n
  at Task.exit 

@SteveMcArthur
Copy link
Contributor Author

Ok - seem to have tracked the problem down to the latest versions of event-emitter-grouped and joe. When I fix the event-emitter-grouped module at v2.4.3 and joe at v1.6.0 the problem is fixed. This means going in to the node_modules directory after they have been installed and deleting the event-emitter-grouped and joe folders then editing the installed docpad package file to fix the versions and run cake install again.

@balupton
Copy link
Member

balupton commented Jun 27, 2016

Any idea why this was manifesting itself in caterpillar? Ah write, DocPad would have already shutdown the buffer. So it seems that DocPad is getting the shutdown signal, while things are still happening.

Definitely related to TaskGroup v5, which is used by those versions of event-emitter-grouped and joe.

I wonder if completing the updating of deps #1045 will solve this.

@SteveMcArthur
Copy link
Contributor Author

Would it be worthwhile for the moment to set event-emitter-grouped and joe to the specific version in the package.json just for the moment?

@balupton
Copy link
Member

Yeah. Probably. Highest priority for me is getting more donations or work. You have publish access right? Feel free to release.

@SteveMcArthur
Copy link
Contributor Author

OK - pushed to git but I don't have access to publish to npm.

@balupton
Copy link
Member

What is your npm username?

@SteveMcArthur
Copy link
Contributor Author

stevemc

@balupton
Copy link
Member

Added

@SteveMcArthur
Copy link
Contributor Author

OK - pushed up version 6.78.6 of Docpad and plugin tests now complete. You will need to clear your cache on travis otherwise they will still fail there.

@Aglezabad
Copy link

Good morning:

I have checked my plugin (UnivUnix/docpad-plugin-api) and I can reproduce the same issue in TravisCI. Also, I've checked other Docpad plugins because I thought that I was doing something wrong, but I don't get any positive results. Could you provide me some help with that?

Regards.

P.D: I'm using the TravisCI open service, so I think that everything you need is visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants