added hostname configuration #737
Conversation
| # Log | ||
| address = opts.serverHttp.address() | ||
| serverHostname = if address.address is '0.0.0.0' then 'localhost' else address.address | ||
| serverHostname = address.address #if address.address is '0.0.0.0' then 'localhost' else address.address |
There was a problem hiding this comment.
Does this output 0.0.0.0 now when null/localhost is set?
There was a problem hiding this comment.
Actually on my tests, it still outputs localhost, which is strange. Also on the current version, even if it's listening on 0.0.0.0 it's saying localhost, which made me think it wouldn't listen on all interfaces, i.e only on loopback. I think it'd be better if it outputs exactly what it is listening on?
|
Yeah maybe. It could be an aliasing thing in more recent versions of the server stuff. My concern is if we list 0.0.0.0 that could seem strange for people who are expecting localhosg. Will merge tomorrow :-) |
|
While I understand your concern, I think calling it localhost when it's On Mon, Dec 16, 2013 at 1:47 PM, Benjamin Arthur Lupton <
|
|
Released to v6.58.2. Changed the localhost display line to check for |
- v6.58.2 December 18, 2013 - Can now change the hostname that we listen to via the `hostname` configuration option - Thanks to [Dario](https://github.com/radiodario) for [pull request #737](#737) - Updated dependencies
|
Woohoo! Thanks!
|
This is in reponse to #642