Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of arguments on container.addSlider #42

Open
runegan opened this issue Sep 14, 2017 · 1 comment
Open

Fix number of arguments on container.addSlider #42

runegan opened this issue Sep 14, 2017 · 1 comment
Labels
enhancement New feature or request minor ui
Milestone

Comments

@runegan
Copy link
Member

runegan commented Sep 14, 2017

Original report by Remco Janssen (Bitbucket: [Remco Janssen](https://bitbucket.org/Remco Janssen), ).


Not sure why this is a problem. Should this be converted to an options object?

Warning: 297:13 warning Method 'addSlider' has too many parameters (5). Maximum allowed is 4 max-params

See: https://bitbucket.org/motiondesign/aequery/src/4fa3668468d17139f7f52924a7b0a4c325842c71/lib/ui/container.js?fileviewer=file-view-default#container.js-297

@runegan
Copy link
Member Author

runegan commented Sep 14, 2017

Original comment by Rune Gangsø (Bitbucket: runegan, GitHub: runegan).


Yeah, option object would be better, and it matches the api of the other addX methods.

Max params is set to 4 because it is difficult to know/nicely code all the params correctly when there are too many. I think after 4 you start struggling with line length and argument order.

@runegan runegan added minor ui enhancement New feature or request labels Feb 6, 2021
@runegan runegan added this to the 1.0 Release milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor ui
Projects
None yet
Development

No branches or pull requests

1 participant