Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strong-migrations warns about dangerous operation when adding foreign key #48

Closed
rchoquet opened this issue Jul 29, 2021 · 0 comments · Fixed by #63
Closed

strong-migrations warns about dangerous operation when adding foreign key #48

rchoquet opened this issue Jul 29, 2021 · 0 comments · Fixed by #63
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rchoquet
Copy link
Contributor

When using safe-pg-migrations together with https://github.com/ankane/strong_migrations, the latter warns about add_foreign_key being a dangerous operation.

safe-pg-migrations makes it a safe operation by doing it in two steps (adding as not valid / validate), adding a foreign key could be marked as safe (as done with add_index) by safe-pg-migrations

@rchoquet rchoquet added the enhancement New feature or request label Jul 29, 2021
@ThHareau ThHareau added the good first issue Good for newcomers label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

2 participants