Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type alias for accessing Versioned enum #4

Closed
jam1garner opened this issue Aug 27, 2021 · 1 comment
Closed

Add type alias for accessing Versioned enum #4

jam1garner opened this issue Aug 27, 2021 · 1 comment

Comments

@jam1garner
Copy link
Contributor

I believe it would be desirable to provide an alias such as:

pub type AnyVersion<T> = <T as obake::Versioned>::Versioned;

reasoning:

  • less eye-sore
  • "reads" better, making it easier for new users to understand
  • removes redundancy of typing out "Versioned" twice, which honestly took me all of 5 minutes to get sick of :P

Willing to PR such a change but didn't want to so without first seeing if it's desirable. Name is just the first thing I thought of and ultimately not important if you have one in mind.

@doctorn
Copy link
Owner

doctorn commented Aug 31, 2021

Absolutely great idea, just added with my most recent commit. Will merge your PR and then publish a new version.

@doctorn doctorn closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants