Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony deprecation #497

Closed
dannyvw opened this issue Jun 1, 2023 · 2 comments · Fixed by #498
Closed

Symfony deprecation #497

dannyvw opened this issue Jun 1, 2023 · 2 comments · Fixed by #498

Comments

@dannyvw
Copy link
Contributor

dannyvw commented Jun 1, 2023

Method "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface::collect()" might add "void" as a native return type declaration in the future. Do the same in implementation "Doctrine\Bundle\MigrationsBundle\Collector\MigrationsCollector" now to avoid errors or add an explicit @return annotation to suppress this message.
@greg0ire
Copy link
Member

greg0ire commented Jun 1, 2023

Do you want to send a PR that does this?

@dannyvw
Copy link
Contributor Author

dannyvw commented Jun 2, 2023

#498

@dannyvw dannyvw mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added type declaration to MigrationsCollector::collect() dannyvw/DoctrineMigrationsBundle
2 participants
@greg0ire @dannyvw