Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package incorrectly states that it does provide laminas/laminas-cache-storage-implementation #820

Closed
boesing opened this issue Oct 1, 2023 · 3 comments · Fixed by #821
Closed
Labels
Milestone

Comments

@boesing
Copy link
Contributor

boesing commented Oct 1, 2023

As per composer.json, this package is stating that it provides laminas/laminas-cache-storage-implementation via provide.
Only packages which do actually provide an implementation should use provide.

There is a good read about dependency inversion here.

Please remove this from the projects composer.json to avoid future problems with incompatibilities between laminas-cache and doctrine/doctrine-module.

@TomHAnderson
Copy link
Member

100% @boesing Do you want to provide a PR to put your name in the repo? Else it's a simple fix I'll do promptly.

@TomHAnderson TomHAnderson added this to the 6.0.5 milestone Oct 15, 2023
@driehle driehle added the Bug label Oct 15, 2023
@boesing
Copy link
Contributor Author

boesing commented Oct 17, 2023

Created #821, feel free to re-target to 6.0.x in case you want to release this as a patch.

@driehle driehle linked a pull request Oct 18, 2023 that will close this issue
@driehle
Copy link
Member

driehle commented Oct 21, 2023

Closed with #821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants