Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ZendDeveloperToolbar integration #110

Closed
romankonz opened this issue Nov 20, 2014 · 6 comments
Closed

improve ZendDeveloperToolbar integration #110

romankonz opened this issue Nov 20, 2014 · 6 comments
Assignees
Labels
Bug Something isn't working

Comments

@romankonz
Copy link
Contributor

$queryBuilder->find(...)->limit(1)->skip(1) is shown as 3 queries.

A note is shown that the integration has to be improved, so i think it's known that there are problems with it.

@romankonz
Copy link
Contributor Author

i've checked that. This is related to doctrine/mongodb-odm#471.

I think there is no good solution for now, until it's possible to get only "real" queries.
$dm->createQueryBuilder(Message::class)->find()->limit(1) does report 0 queries
$dm->createQueryBuilder(Message::class)->find()->limit(1)->getQuery()also reports 0 queries.
but when calling $dm->createQueryBuilder(Message::class)->find()->limit(1)->getQuery()->execute();2 queries are reported.

I'll take a quick look at it in mongo odm.

@Ocramius
Copy link
Member

I think this is not an issue of the module then, and the issue should be closed.

@Ocramius Ocramius added the Bug Something isn't working label Nov 21, 2014
@Ocramius Ocramius self-assigned this Nov 21, 2014
@romankonz
Copy link
Contributor Author

The integration can still be improved.
Even if the logging in mongo odm is improved, the output isn't really useful.
Also it returns ALWAYS a hard coded query time of 0ms.

The funniest thing is, that the queries on top doesn't produce any server communication because i did not fetched any data from the cursor.

I think the integration should be improved or removed.
Maybe we can register to doctrine odm events to get more useful information?

@Ocramius
Copy link
Member

@romankonz maybe just improve the native ODM logger?

@romankonz
Copy link
Contributor Author

In my opinion both should be improved.
Until the odm logger is improved, nobody should use the integration.

But i agree, this ticket should be closed, because the problem in the description is related to odm logger.

@gianarb
Copy link
Contributor

gianarb commented Apr 9, 2015

Thanks i close this issue

@gianarb gianarb closed this as completed Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants