Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCOM-255: Add support for using TABS (for indentation) in DocBlock Annotations #78

Closed
guilhermeblanco opened this issue Mar 27, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@guilhermeblanco
Copy link
Member

From @doctrinebot on October 12, 2014 20:8

Jira issue originally created by user henrywood:

Apparently any annotation that contains at least one TAB character is ignored.

The reason/bug resides in \Doctrine\Common\Annotations\DocParser->findInitialTokenPosition() on line 351

// if the @ is preceded by a space or * it is valid

Thanks

Copied from original issue: doctrine/common#564

@guilhermeblanco
Copy link
Member Author

From @doctrinebot on October 13, 2014 0:24

Comment created by @Ocramius:

[~henrywood] this seems to be easily fixable by using something like preg_match('/^(\\t](\\*)$/', $input[$pos - 1)): can you provide a PR?

I'm just not sure about the performance impact here.

Note that JIRA screws with my regex in the quoted text, as escape sequences don't match what I entered.

@poldridge
Copy link
Contributor

#70

@Tobion
Copy link
Contributor

Tobion commented Oct 24, 2016

@Ocramius I think this is fixed by #99 as well.

@Ocramius Ocramius added this to the v1.3.0 milestone Oct 25, 2016
@Ocramius
Copy link
Member

Indeed, closing here. Thanks for the poke, @Tobion. #99 is just #70 ported forward/rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants