Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate RequireOneLineDocComment in ruleset #318

Closed
tomudding opened this issue Apr 27, 2023 · 1 comment · Fixed by #319
Closed

Duplicate RequireOneLineDocComment in ruleset #318

tomudding opened this issue Apr 27, 2023 · 1 comment · Fixed by #319

Comments

@tomudding
Copy link
Contributor

Functionally this is not a problem, however, if the rule should ever be removed the other one may be left in the ruleset (and cause an headache when trying to figure out why nothing was affected).

First instance:

<!-- Require comments with single line written as one-liners -->
<rule ref="SlevomatCodingStandard.Commenting.RequireOneLineDocComment"/>

Second instance:

<!-- Require One Line Doc Comment where there's only 1 annotation present -->
<rule ref="SlevomatCodingStandard.Commenting.RequireOneLineDocComment"/>

@greg0ire
Copy link
Member

Oh wow well spotted… can you please send a merge request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants