Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ArrayCollection $_elements protected for extensibility #730

Closed
redthor opened this issue Jul 21, 2016 · 3 comments
Closed

Make ArrayCollection $_elements protected for extensibility #730

redthor opened this issue Jul 21, 2016 · 3 comments
Assignees

Comments

@redthor
Copy link

redthor commented Jul 21, 2016

Enhancement request.

Could we get ArrayCollection::$_elements to be visibility protected? toArray() will not pass by reference and so we would have to pull all the elements out and then reload them if we want to do something like a reorder().

It would go well with the new Collection enhancement doctrine/mongodb-odm#1385

( See also related doctrine/mongodb-odm#1458 )

Thanks!

@malarzm
Copy link
Member

malarzm commented Jul 22, 2016

Just a small clarification, collection enhancement in question is doctrine/mongodb-odm#1219 as support for sharded collection is for Mongo related stuff

@Ocramius
Copy link
Member

Please see doctrine/collections#80

@Ocramius Ocramius self-assigned this Jul 22, 2016
@stof
Copy link
Member

stof commented Jul 22, 2016

@redthor I don't see anything in doctrine/mongodb-odm#1385 related to doctrine/collection. It is talking about MongoDB collections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants