DDC-1515 - Merge from 2.1.x

doctrine · Dec 11, 2011 · bd0fb57 · bd0fb57
1 parent 954b507
commit bd0fb57
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 2 deletions.
diff --git a/lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php b/lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php
@@ -244,6 +244,7 @@ protected function gatherRowData(array $data, array &$cache, array &$id, array &
 
             if (isset($cache[$key]['isMetaColumn'])) {
                 if ( ! isset($rowData[$dqlAlias][$cache[$key]['fieldName']]) || $value !== null) {
+                    $nonemptyComponents[$dqlAlias] = true;
                     $rowData[$dqlAlias][$cache[$key]['fieldName']] = $value;
                 }
 

diff --git a/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php b/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php
@@ -332,9 +332,9 @@ protected function hydrateRowData(array $row, array &$cache, array &$result)
         // Hydrate the data chunks
         foreach ($rowData as $dqlAlias => $data) {
             $entityName = $this->_rsm->aliasMap[$dqlAlias];
-
+ 
             if (isset($this->_rsm->parentAliasMap[$dqlAlias])) {
-                // It's a joined result
+               // It's a joined result
 
                 $parentAlias = $this->_rsm->parentAliasMap[$dqlAlias];
                 // we need the $path to save into the identifier map which entities were already

diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1515Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1515Test.php
@@ -0,0 +1,64 @@
+<?php
+
+namespace Doctrine\Tests\ORM\Functional\Ticket;
+
+
+/**
+ * @group DDC-1515
+ */
+class DDC1515Test extends \Doctrine\Tests\OrmFunctionalTestCase
+{
+    public function setUp()
+    {
+        parent::setUp();
+        $this->_schemaTool->createSchema(array(
+            $this->_em->getClassMetadata(__NAMESPACE__ . '\\DDC1515Foo'),
+            $this->_em->getClassMetadata(__NAMESPACE__ . '\\DDC1515Bar'),
+        ));
+    }
+
+    public function testIssue()
+    {
+        $bar = new DDC1515Bar();
+        $this->_em->persist($bar);
+        $this->_em->flush();
+
+        $foo = new DDC1515Foo();
+        $foo->bar = $bar;
+        $this->_em->persist($foo);
+        $this->_em->flush();
+        $this->_em->clear();
+
+        $bar = $this->_em->find(__NAMESPACE__ . '\DDC1515Bar', $bar->id);
+        $this->assertInstanceOf(__NAMESPACE__.'\DDC1515Foo', $bar->foo);
+    }
+}
+
+/**
+ * @Entity
+ */
+class DDC1515Foo
+{
+    /**
+     * @OneToOne(targetEntity="DDC1515Bar", inversedBy="foo") @Id
+     */
+    public $bar;
+}
+
+/**
+ * @Entity
+ */
+class DDC1515Bar
+{
+    /**
+     * @Id @Column(type="integer") @GeneratedValue
+     */
+    public $id;
+
+    /**
+     * @OneToOne(targetEntity="DDC1515Foo", mappedBy="bar")
+     */
+    public $foo;
+}
+
+