Skip to content

Loading…

DDC-2031: doctrine:generate:entities - Alternate (scoped) Namespace Syntax not supported #2709

Closed
doctrinebot opened this Issue · 7 comments

2 participants

@doctrinebot

Jira issue originally created by user ilaurillard:

My preferred Syntax:

namespace foo
{
use ...;
class { ... }
}

seems not to be supported.

Setters/Getters are inserted before the last curly closing bracket - but that is the closing Namespace scope!

@doctrinebot

Comment created by @ocramius:

[~ilaurillard] entities are per-file anyway, you'd have only one namespace.

namespace Foo
{
    use AAA;
    class Bar {}
}

is exactly like writing

namespace Foo
use AAA;
class Bar {}
@doctrinebot

Comment created by ilaurillard:

One namespace per file may be correct, but only considering autoloading issues.
Have a look to the symfony "bootstrap.php.cache" file for an example of multiple namespace and classes.
Doctrine should have a similar "compiling" option.

I know of the standard syntax - thats why i wrote: "my preferred syntax".

I just may live with the standard syntax - you may want to at least mention in the docs that you have to use standard syntax, else your compiled entities fatal.

@doctrinebot

Comment created by @ocramius:

[~ilaurillard] not really sure classcache is doctrine's problem. Playing with reflection, any third party (Symfony2 here) can handle that without string concat

@doctrinebot

Comment created by stof:

@Marco The issue is not about creting a class cache but about editing entities with the EntityGenerator when the code uses the syntax with braces.

@doctrinebot

Comment created by @ocramius:

[stof] yes, but I think the code generator becomes quite too complex when we add all these details... What I was thinking is that using an alternate syntax to ease the task [ilaurillard] exposed as an example is anyway a bit weak. I don't see this coming without code generation projects going on first.

@doctrinebot

Comment created by @ocramius:

Alternate code generators project is not yet on roadmap.

@doctrinebot

Issue was closed with resolution "Won't Fix"

@Ocramius Ocramius was assigned by doctrinebot
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.