Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-2273: [GH-566] Added missing return statement to AbstractCommand. #2972

Closed
doctrinebot opened this issue Feb 3, 2013 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@doctrinebot
Copy link

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: #566

Message:

The AbstractCommand::execute() method should return an integer, or null.

Although in PHP, omitting the return statement is equivalent to returning null, it is recommended to put an explicit return to clearly differentiate it from return void.

I've added return 0; here, keeping the existent behavior.

@doctrinebot
Copy link
Author

Comment created by @beberlei:

A related Github Pull-Request [GH-566] was closed
#566

@doctrinebot
Copy link
Author

Comment created by @FabioBatSilva:

Merged : d3cbdfc

@doctrinebot
Copy link
Author

Issue was closed with resolution "Fixed"

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-566] was closed:
doctrine/dbal#566

@doctrinebot doctrinebot added this to the 2.4 milestone Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants