DDC-2273: [GH-566] Added missing return statement to AbstractCommand. #2972

Closed
doctrinebot opened this Issue Feb 3, 2013 · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: #566

Message:

The AbstractCommand::execute() method should return an integer, or null.

Although in PHP, omitting the return statement is equivalent to returning null, it is recommended to put an explicit return to clearly differentiate it from return void.

I've added return 0; here, keeping the existent behavior.

@doctrinebot

Comment created by @beberlei:

A related Github Pull-Request [GH-566] was closed
#566

@doctrinebot

Comment created by @FabioBatSilva:

Merged : d3cbdfc

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-566] was closed:
doctrine/dbal#566

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.4 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment