Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-2747: Doctrine Checking Null but not default #3491

Closed
doctrinebot opened this issue Oct 17, 2013 · 4 comments
Closed

DDC-2747: Doctrine Checking Null but not default #3491

doctrinebot opened this issue Oct 17, 2013 · 4 comments
Assignees
Labels

Comments

@doctrinebot
Copy link

Jira issue originally created by user spuy767:

Doctrine ORM checks fields for the acceptance of null values on entity commits. It does not, however, check if those same fields allow have default values. Our DBA likes to specify not-null, in addition to a default, so that a manual entry of a null value cannot take place. It seems that Doctrine should check that the field has a default value after it checks if it accepts null, in order to prevent errors on not-null fields with default values that are not passed explicit values.

@doctrinebot
Copy link
Author

Comment created by @Ocramius:

[~spuy767] this is not up to doctrine to check. If your schema enforces non-null fields, so should your object graph do as well.

That means that your setters or constructors should guarantee consistent state of the properties in your entities at any time, regardless of the ORM.

@doctrinebot
Copy link
Author

Issue was closed with resolution "Won't Fix"

@doctrinebot
Copy link
Author

Comment created by @Ocramius:

Also a side-note: the ORM always assumes that your data is valid. It just limits itself to saving and loading it.

@doctrinebot
Copy link
Author

Comment created by spuy767:

Thank you for the clarification, I got a ticket from a dev and our DBA said it was doctrine was throwing the error, but now that I've looked at the Entity, he has no default value assigned to his private variable and doctrine is just doing what it's told.

Clay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants