Skip to content

Loading…

DDC-2798: [GH-849] Error with Same Field, Multiple Values, Criteria and QueryBuilder #3547

Closed
doctrinebot opened this Issue · 3 comments

2 participants

@doctrinebot

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of bsahlhof:

Url: #849

Message:

I just posted another quick patch for this, but after reviewing some of the tests, I realized I needed to change it slightly.

The bug appeared when using same field for 2 different expression values within Criteria, then adding to QueryBuilder.

This makes sure the parameters are unique, avoiding the issue.

Example of issue:

Criteria of Field1 = Value1 OR (Field1 = Value2 AND field2 = true) passed to QueryBuilder
In this case, the parameter :Field1 was duplicated, throwing an error on evaluation of DQL.

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-849] was closed:
#849

@doctrinebot

Comment created by @ocramius:

Merged: 0e3c57d

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.5 milestone
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.