Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-2798: [GH-849] Error with Same Field, Multiple Values, Criteria and QueryBuilder #3547

Closed
doctrinebot opened this issue Nov 18, 2013 · 3 comments
Assignees
Labels
Milestone

Comments

@doctrinebot
Copy link

Jira issue originally created by user @doctrinebot:

This issue is created automatically through a Github pull request on behalf of bsahlhof:

Url: #849

Message:

I just posted another quick patch for this, but after reviewing some of the tests, I realized I needed to change it slightly.

The bug appeared when using same field for 2 different expression values within Criteria, then adding to QueryBuilder.

This makes sure the parameters are unique, avoiding the issue.

Example of issue:
Criteria of Field1 = Value1 OR (Field1 = Value2 AND field2 = true) passed to QueryBuilder
In this case, the parameter :Field1 was duplicated, throwing an error on evaluation of DQL.

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-849] was closed:
#849

@doctrinebot
Copy link
Author

Comment created by @Ocramius:

Merged: 0e3c57d

@doctrinebot
Copy link
Author

Issue was closed with resolution "Fixed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants