DDC-3967: Identifier is cached with wrong type

[doctrinebot]

Jira issue originally created by user janlanger:

Consider this entity:

/****
 * @ORM\Entity
 * @ORM\Cache(usage="READ_ONLY")
 */
class Foo
{

/****
 * @ORM\Id()
 * @ORM\Columns(type="integer")
 * @var integer
 */
private $id;

// ... rest of entity
}

The entity is loaded like this:

$this->em->find(Foo::class, "123");

(note the integer identifier passed as string). When entity is loaded directly from database, the value in property "id" is integer. But second time, when the entity is loaded from second level cache, the id property will have string value "123".

It is caused by this line https://github.com/doctrine/doctrine2/blob/d72ad9cc50208153160edfa9b3bd7a23fbec0cee/lib/Doctrine/ORM/Cache/DefaultEntityHydrator.php#L76 where value in original data is overriden by data from cache key.

This is btw second bug i found caused by this line, the previous is #DDC-3950

[doctrinebot]

• is referenced by DDC-4016: [GH-1568] Identifier is cached with wrong type

[doctrinebot]

Issue was closed with resolution "Fixed"