DDC-63: missing time and date SQL declaration for all platforms #5139

Closed
doctrinebot opened this Issue Oct 27, 2009 · 5 comments

2 participants

@doctrinebot

Jira issue originally created by user chriswest:

The following SQL deleration functions are missing / incomplete within all Platform classes:

public function getDateTypeDeclarationSql(array $fieldDeclaration)
public function getTimeTypeDeclarationSql(array $fieldDeclaration)

This leads to fatal errors when using time column definitions with e.g. a mysql backend:
PHP Fatal error: Call to undefined method Doctrine\DBAL\Platforms\MySqlPlatform::getTimeTypeDeclarationSql() .../doctrine/lib/Doctrine/DBAL/Types/TimeType.php

Patch attached (I've used the oracle and mssql declarations from doctrine 1.x, "DATE' was used for both oracle 'date' and 'time'c olumns...).
Also, the function getTimeTypeDeclarationSql() was completely missing in AbstractPlatform.

@doctrinebot

Comment created by romanb:

Is this a patch against HEAD? I'm asking because at least getDateTypeDeclarationSql seems to be present and functional in the latest code. getTimeTypeDeclarationSql seems to be missing indeed. Sorry for that. Will be scheduled for the soon to come alpha3 release.

@doctrinebot

Comment created by chriswest:

Sorry, maybe I had to be more precise:

  • getTimeTypeDeclarationSql is missing for any platform
  • both are missing for oracle and mssql

    (that's what I've included in the patch)

Anyway: No need for you to be sorry :) You're doing an awesome job with doctrine and I appreciate it a lot.

@doctrinebot

Comment created by @beberlei:

Applied and fixed, thanks for the patch.

@doctrinebot

Issue was closed with resolution "Fixed"

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.0-ALPHA3 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment