Update DefaultRepositoryFactory.php

[alexanderwink]

getRepository() does not support different databases for the same entity class due to the lookup in repositoryList. By adding the database name (or any other unique name for the specific database/connection) the lookup works for identical entities in different databases.

[Ocramius]

We don't support multiple DBs per single EntityManager unless you abstract them away into a single aggregate Connection instance.

The edit looks invalid to me.

[alexanderwink]

Sorry. Not multiple DBs per EntityManager. Multiple EntityManagers.

$tRepo = $app["orm.ems"][0]->getRepository("some\namespace\Transfer");

$tRepo2 = $app["orm.ems"][1]->getRepository("some\namespace\Transfer");

The second repo will be the same as the first one due to the if-statement on (original) line 46.

[Ocramius]

Seems more like a hack to me, as we do not have a reliable way to differentiate EntityManager instances except for their object hash

[Ocramius]

@akexakex why not just using the spl_object_hash($entityManager) as actual index prefix?

[stof]

In this case, I think you should use a separate repository factory for each entity manager

[Ocramius]

@stof the problem still stands: the API doesn't protect from misuse (and it should)

[stof]

@Ocramius reusing the same instances for several entity managers will break in many other places as well (I'm not even sure it is safe to reuse the same Configuration instance)

[Ocramius]

I'm not even sure it is safe to reuse the same Configuration instance

That's exactly why it exploded in this case. I think we should provide a fix :-)

[alexanderwink]

Some background info:
There are two identical databases. They differ only in content due to regulatory requirements.

I configure two EntityManagers, one for each database. I then get a repository (entity is called Transfer) from each EntityManager.
How is this considered misuse? What would the appropriate use be?

Personally I easily resolved this by implementing my own RepositoryFactory. I just wanted to inform you of a potential bug.

[Ocramius]

I'm working on a cleaner fix+test.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 13 October 2014 18:47, akexakex notifications@github.com wrote:

Some background info:
There are two identical databases. They differ only in content due to
regulatory requirements.

I configure two EntityManagers, one for each database. I then get a
repository (entity is called Transfer) from each EntityManager.
How is this considered misuse? What would the appropriate use be?

Personally I easily resolved this by implementing my own
RepositoryFactory. I just wanted to inform you of a potential bug.

—
Reply to this email directly or view it on GitHub
#1159 (comment).

[stof]

@akexakex you should not share the same Configuration instance between both EntityManager instances. doctrine does not take this case into account currently

[Ocramius]

@stof I actually have few systems relying on this as well, so I'll have to go through the different use-cases here.

[alexanderwink]

I have two configuration instances as well. The problem is with the default RepositoryFactory implementation which uses an internal lookup-array that only uses the Entity as key.

[stof]

@akexakex are you sharing the same RepositoryFactory instance between your 2 configurations ?

[Ocramius]

It is shared by default

[stof]

@Ocramius this will not share it between different Configuration instances

[stof]

and your link is not even related to the RepositoryFactory

[alexanderwink]

Yes the RepositoryFactory is shared.

[stof]

@akexakex as I said previously, doctrine does not support the sharing between entity managers properly for its stack yet. You should use 2 instances for now

[Ocramius]

See #1160