New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity in *-to-one association builder #1229
Identity in *-to-one association builder #1229
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3461 We use Jira to track the state of pull requests and the versions they got |
@guiwoda the alignment in the code is messed up. Also, please only test bits relevant to your changes. |
->build() | ||
); | ||
|
||
$this->assertEquals(array('groups' => array ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion is too fragile
@Ocramius you mean in the tests? Also, all the tests I commited are related to my change. Please review it again if that's not clear. |
Please build smaller assertions then, checking things such as |
Poking @beberlei for a decision on whether we want this or not |
Decided to merge, but will do as soon as I have free time to check it carefully. |
Will merge as-is. If the tests are too fragile, we can reduce their scope later on. |
Merged after a rebase at a13143b |
Please see b3a6fb7 for some changes to this behavior. |
Great! I always found the "is" syntax confusing as a setter. |
Added the ability to set identity with associations through the
ClassMetadataBuilder
/AssociationBuilder
classes.Added multiple tests to ensure that all association scenarios behave as expected.