Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embeddedClasses support in mapped superclasses #1321

Merged
merged 3 commits into from Mar 10, 2015
Merged

embeddedClasses support in mapped superclasses #1321

merged 3 commits into from Mar 10, 2015

Conversation

vvh-empora
Copy link
Contributor

...for JoinedSubclassPersister.php

...for JoinedSubclassPersister.php
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3597

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

Ocramius commented Mar 3, 2015

Requires test case

@vvh-empora
Copy link
Contributor Author

help is there a short tutorial how can i write a unittest for doctrine?

@Ocramius
Copy link
Member

Ocramius commented Mar 3, 2015

Can you just run it with sqlite instead? ./vendor/bin/phpunit should be sufficient for that

@vvh-empora
Copy link
Contributor Author

will this fix merge?

@vvh-empora
Copy link
Contributor Author

ping @Ocramius

@k-k
Copy link

k-k commented Mar 10, 2015

+1. Just ran into this today, Class Table Inheritance with embedded objects.

@eglizzy
Copy link

eglizzy commented Mar 10, 2015

+1

1 similar comment
@lucky7id
Copy link

👍

@Ocramius
Copy link
Member

Good to go, thanks :-)

@Ocramius Ocramius self-assigned this Mar 10, 2015
Ocramius added a commit that referenced this pull request Mar 10, 2015
@Ocramius Ocramius merged commit a3f9f15 into doctrine:master Mar 10, 2015
@Ocramius Ocramius changed the title embeddedClasses support... embeddedClasses support in mapped superclasses Mar 10, 2015
@lcobucci lcobucci added this to the 2.5 milestone Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants