[DDC-2224] Honor convertToDatabaseValueSQL() in DQL query parameters #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3625 We use Jira to track the state of pull requests and the versions they got |
| @@ -250,7 +265,7 @@ private function _parse() | |||
| return $this->_parserResult; | |||
| } | |||
|
|
|||
| $hash = $this->_getQueryCacheId(); | |||
| $hash = $this->_getQueryCacheId($types); | |||
There was a problem hiding this comment.
For consistency with the rest of the class, I'd say that _getQueryCacheId directly accesses $this->_parsedTypes instead, no?
There was a problem hiding this comment.
Good point, I'll change this!
Ocramius
added a commit
that referenced
this pull request
Mar 25, 2015
[DDC-2224] Honor convertToDatabaseValueSQL() in DQL query parameters
|
👍 |
1 similar comment
|
👍 |
|
Great, thanks for merging! It would be nice to change DDC-2224 from "invalid" to "fixed" also. Any chance this fix can land in the 2.5.0 release? |
|
@BenMorel this will land in |
|
@Ocramius 👍 Thanks! |
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the abandoned #574 by @mnapoli, that fixes DDC-2224.
At the time, @beberlei closed the PR for the following reason, deemed unfixable:
This PR re-integrates the original fix, and offers a solution to the above issue: take the parameter types into account when checking the local
ParserResultand the query cache.In addition to the test for the DDC-2224 issue, I added a test to ensure that changing a parameter type invalidates the cache.