Fixes ClassMetadata wakeupReflection with embeddable and StaticReflectio... #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3684 We use Jira to track the state of pull requests and the versions they got |
|
Seems straightforward: merging as soon as I can. |
|
I have successfully patch 2.5 to use embedded objects with doctrine:generate:entities command. It resolves all errors that occurred in stable version. Please merge it into master as soon as possible. |
Ocramius
added a commit
that referenced
this pull request
Jul 15, 2015
…icreflection-serialization-fix-2.5' into 2.5 Close #1381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nService
When the
StaticReflectionServiceis used, then the wakeupReflection will cause an error with embedded properties. This is because thegetAccessiblePropertymethod of theStaticReflectionServicewill always return null, so the parentReflFields will only have null values.I found this problem when I was generating a Symfony form based on an entity with embedded properties.