Type annotation correction in ResultSetMappingBuilder#addJoinedEntityFromClassMetadata() $relation (should be string)
#1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for the method ‘addJoinedEntityFromClassMetadata’ is wrong. As we can see currently says you need to pass an object and that is wrong. The $relation variable is passed to ‘addJoinedEntityResult’ which is using it as a ‘string’.
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3974 We use Jira to track the state of pull requests and the versions they got |
|
@aleeeftw thanks! |
|
@Ocramius thank you too! |
|
@Ocramius can this phpdoc fix be backported in maintenance branches too ? The fix was merged 1.5 year ago, but my project still has the wrong phpdoc, because the master branch has not been released since then |
|
@stof doing that, gimme a sec |
Ocramius
added a commit
that referenced
this pull request
May 20, 2017
…g-builder' into 2.5 Backport #1541 to 2.5
Ocramius
changed the title
ResultSetMappingBuilder#addJoinedEntityFromClassMetadata() $relation (should be string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the method ‘addJoinedEntityFromClassMetadata’ is a little bit wrong. As we can currently see it says you need to pass an object instead of a string. The $relation variable is passed to ‘addJoinedEntityResult’ which is using it as a string.