Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed coding standards in the Tools namespace #489

Merged
merged 3 commits into from Nov 3, 2012

Conversation

stof
Copy link
Member

@stof stof commented Oct 22, 2012

This also fixes some command exit code in case of failure and removes an unused private method

@doctrinebot
Copy link

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2095

@guilhermeblanco
Copy link
Member

Could you please rebase for later evaluation?

@stof
Copy link
Member Author

stof commented Nov 3, 2012

rebased

@guilhermeblanco
Copy link
Member

@stof I reviewed the patch and it seems valid.
As soon as you fix the tests, I'm gonna merge. =)

@stof
Copy link
Member Author

stof commented Nov 3, 2012

@guilhermeblanco done

guilhermeblanco added a commit that referenced this pull request Nov 3, 2012
Fixed coding standards in the Tools namespace
@guilhermeblanco guilhermeblanco merged commit fc40c43 into doctrine:master Nov 3, 2012
@stof stof deleted the cs_fixes branch August 22, 2014 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants