Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Id generator compat #5549

Closed
wants to merge 2 commits into from
Closed

[3.x] Id generator compat #5549

wants to merge 2 commits into from

Conversation

Ma27
Copy link
Contributor

@Ma27 Ma27 commented Dec 11, 2015

in doctrine 2.4 the EntityManagerInterface was introduced.
Many parts of the code were changed, so almost everything was changed. That wasn't changed in the Id sub-package containing all identity generators...

@Ocramius Ocramius self-assigned this Dec 11, 2015
@Ocramius
Copy link
Member

This can't be fixed in 2.x due to the interface changes, sorry (BC break)

@Ocramius Ocramius closed this Dec 11, 2015
@Ma27
Copy link
Contributor Author

Ma27 commented Dec 11, 2015

can this be merged in 3.x?

@Ma27 Ma27 changed the title Id generator compat [3.x] Id generator compat Dec 11, 2015
@Ocramius
Copy link
Member

3.x is not started yet, but we'll probably re-design many of these low-level components then.

@Ocramius Ocramius added this to the 3.0 milestone Dec 11, 2015
@Ocramius Ocramius reopened this Dec 11, 2015
@Ocramius
Copy link
Member

@Ma27 reopening and assigning a milestone

@Ma27
Copy link
Contributor Author

Ma27 commented Dec 11, 2015

ok, thx

@Ma27
Copy link
Contributor Author

Ma27 commented Jan 3, 2016

I'll work on it again (and fix the broken build) when 2.6 is released and the work on 3.x starts

@Majkl578
Copy link
Contributor

This has now been handled in develop (aka 3.x) as part of #6599.
I'm closing this as it can't be done for master (2.x) due to BC.

@Majkl578 Majkl578 closed this Aug 29, 2017
@Majkl578 Majkl578 assigned Majkl578 and unassigned Ocramius Aug 29, 2017
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants