Updated all commands to use the SymfonyStyle #5651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but the |
|
Thanks. I forgot the version bump. Committed. |
|
@hiddewie I'm truly sorry for that! I didn't even see that we had this PR improving the commands. We indeed have much to improve on maintaining doctrine packages but I hope that you feel a bit happy with the fact that, even though is not your code, we now have better output for the commands. |
|
Addressed by #6655 |
|
No problem, I am definitely happy the command output is more beautiful because of the other PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony Style defines one default style for all commands using the Symfony Console code. Because Docrine has a number of commands, it would look nice if the commands made use of the Symfony style. This makes the output more human friendly to read.
Additions and comments are welcome, for example about which style to use for which messages.
All tests pass (although some commands are not tested).
Some text about the style guide is written in http://symfony.com/blog/new-in-symfony-2-8-console-style-guide.