NamingStrategy::joinTableName not being called

[basz]

This problem exists for M2M without a tableName (because a NamingStrategy may take care of the table name) and XML Drivers

Explanation:

Although a joinTable MUST have an tableName eventually, it is actually valid to have it not declared IF a naming strategy would generate one (always true if not defined (null)).

However this XML driver will will parse an omitted declaration as an empty string. The ClassMetadataInfo Class is expecting an unset value or it will break.

ClassMetadataInfo will show a Notice: Uninitialized string offset: 0 which makes sense if you look at

// remember $mapping['joinTable']['name'] is now "";
if (isset($mapping['joinTable']['name']) && $mapping['joinTable']['name'][0] === '`') {

see

More importantly the (default) naming strategy will now never be called and the resulting ClassMetadataInfo has no table name defined, which results in a 'Invalid table name specified' Exception

if ( ! isset($mapping['joinTable']['name'])) {
    $mapping['joinTable']['name'] = $this->namingStrategy->joinTableName($mapping['sourceEntity'], $mapping['targetEntity'], $mapping['fieldName']);
}

see

Please tell me if this is something we can merge without further proof, I don't really understand how to add a test case for it (I have looked at the existing cases, but... pfft)

[Ocramius]

@basz please refer to https://github.com/doctrine/doctrine2/blob/788143dc0313c7522820ebf6057f73881e7190a3/tests/Doctrine/Tests/ORM/Mapping/XmlMappingDriverTest.php

You basically want to create a <join-table/> without a name attribute. This seems invalid though, as the name attribute is required as per XSD specification: https://github.com/doctrine/doctrine2/blob/788143dc0313c7522820ebf6057f73881e7190a3/doctrine-mapping.xsd#L453

[basz]

This seems invalid though, as the name attribute is required as per XSD specification: https://github.com/doctrine/doctrine2/blob/788143dc0313c7522820ebf6057f73881e7190a3/doctrine-mapping.xsd#L453

Hm I did not think about that. Would an empty string be valid according to the xsd?

Otherwise Naming strategies will never be able to kick in for xml schemes

[Ocramius]

Otherwise Naming strategies will never be able to kick in for xml schemes

A join table can be omitted

[basz]

Not if you want to specify other properties. I would argue that the doctrine-mapping.xsd is incorrect on the requirement of the name attribute since doctrine supported NamingStrategies...

This should work IMHO

• join-table name should be autogenerated
• join-column name should be autogenerated

      <join-table>
        <join-columns>
          <join-column referenced-column-name="id" nullable="false" on-delete="CASCADE"/>
        </join-columns>
        <inverse-join-columns>
          <join-column referenced-column-name="id" nullable="false" on-delete="CASCADE"/>
        </inverse-join-columns>
      </join-table>

[Ocramius]

@basz changing the requirement could be done, but is it worth doing?

[basz]

Probably not. but if it is not accurate, why not?

For example skipper will try to generate a join column name when omitted. When asked to stop doing they will probably say it a requirement by declaration.

Op 8 feb. 2016 om 20:51 heeft Marco Pivetta notifications@github.com het volgende geschreven:
@basz changing the requirement could be done, but is it worth doing?

—
Reply to this email directly or view it on GitHub.