-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDC-2780 - Fixed issue with IS NULL on join aliases #5680
Conversation
Why isn't this one merged? |
Without this patch IS NULL and IS NOT NULL expressions don't work in sub-queries. It would be really cool if somebody merge it. |
Yes, I would like to see this merged. Having to fork right now. |
Any workaround for this expect forking or using lazy loading? |
I'm using the "netresearch/composer-patches-plugin" composer package to patch it on update for the last 8 months - it seems ok. |
Would be really great if this PR could be merged. If there's anything against it, what is it? |
A merge here would be great. Any time now. |
I'll take a look on it this evening or tomorrow but would be amazing if @byonchev could sync this branch with master and apply the same conventions we applied there (to make it a bit faster for me to review and merge). |
Just to update you guys, I've discussed this with @guilhermeblanco and the changes are not exactly correct (they're almost right) but I'll fix them and we'll merge this very soon on |
Closing since it's being handled on #6328. |
#3528 Added fallback to SingleValuedPathExpression