Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-2780 - Fixed issue with IS NULL on join aliases #5680

Closed
wants to merge 1 commit into from
Closed

DDC-2780 - Fixed issue with IS NULL on join aliases #5680

wants to merge 1 commit into from

Conversation

byonchev
Copy link

#3528 Added fallback to SingleValuedPathExpression

@kipelovets
Copy link

Why isn't this one merged?

@vbyndych
Copy link

Without this patch IS NULL and IS NOT NULL expressions don't work in sub-queries. It would be really cool if somebody merge it.

@amerryma
Copy link
Contributor

Yes, I would like to see this merged. Having to fork right now.

@fnagel
Copy link

fnagel commented Oct 26, 2016

Any workaround for this expect forking or using lazy loading?

@byonchev
Copy link
Author

I'm using the "netresearch/composer-patches-plugin" composer package to patch it on update for the last 8 months - it seems ok.

@hvt
Copy link

hvt commented Nov 15, 2016

Would be really great if this PR could be merged.

If there's anything against it, what is it?

@HugoMestre
Copy link

A merge here would be great. Any time now.

@lcobucci lcobucci self-assigned this Mar 2, 2017
@lcobucci
Copy link
Member

lcobucci commented Mar 2, 2017

I'll take a look on it this evening or tomorrow but would be amazing if @byonchev could sync this branch with master and apply the same conventions we applied there (to make it a bit faster for me to review and merge).

@lcobucci
Copy link
Member

lcobucci commented Mar 7, 2017

Just to update you guys, I've discussed this with @guilhermeblanco and the changes are not exactly correct (they're almost right) but I'll fix them and we'll merge this very soon on master (and I believe it will only be available for v2.6).

@lcobucci
Copy link
Member

lcobucci commented Mar 7, 2017

Closing since it's being handled on #6328.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants