-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EOL PHP 5.4 from .travis.yml
and composer.json
- Fixes #5862
#5863
Conversation
.travis.yml
and composer.json
- Fixes #5862
@@ -14,7 +14,7 @@ | |||
], | |||
"minimum-stability": "dev", | |||
"require": { | |||
"php": ">=5.4", | |||
"php": ">=5.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to ^5.5 || ^7.0
@Ocramius Done |
@Ocramius 👍 for version support dropping, but this should be done on a new major IMHO. Dropping PHP support is BC break for developers using this bundle under the dropped version. |
This has been discussed ad-nauseam. Dependency requirement bumps (any dependency) are not BC breaks. This will not break running systems, and systems running 5.4 will simply reject Doctrine ORM 2.6.x when running We've also done this previously in the 2.4 -> 2.5 upgrade.
Done it multiple times in Doctrine, in Zendframework and in other libraries: not a problem, and also not perceived as a problem by consumers. Dropping support for un-maintained PHP versions is also the most responsible thing to do from a security perspective. |
Thanks, @tPl0ch! |
@Ocramius I understand, you are technically right. Symfony does not follows this way, so I think it's a matter of choices... Thanks for your explanation anyway. 👍 |
Top of the page says |
Yeas I know, this is was I said:
😉
I totally understand you for this point. 👍 Having same issue for Sonata projects. |
@soullivaneuh In addition to @Ocramius points I also believe that libraries can be a vital driver for new PHP version adoptions this way. When an EOL is reached it's time to increase the pressure on consumers, and libraries like doctrine can instrument a big leverage here. |
See #5862 for more info