Fist steps to close DDC-2134 #5964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the way is ready for handling foreign keys made of multiple columns.
Still has work to do to implement the second part of the algorithm: The actual search for dead entities.
Now the way is ready for handling foreign keys made of multiple columns.
Still has work to do to implement the second part of the algorithm: The actual search for dead entities.
|
@marcobuschini this patch is not fit for core, in my opinion.
Closing here. I agree that this is a much needed tool, but it doesn't fit ORM core. Also: this tool can be implemented without ORM (just use DBAL, look for foreign keys, repeat the same logic there ;-) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request creates a new command
deadentitiesthat seeks for child entities that have no parent. This is for helping people getting to implement referential integrity on databases that didn't have it. It does it all by analyzing the database schema via Doctrine API, and then generating queries to seek for the "missing" data.It still does not work with composite foreign keys, possibly due to my lack of knowledge of the Doctrine schema API, or query language.
Testing data should be inserted by hand in the database, as I do not know how I can violate foreign keys with Doctrine, but everything else should be database independent.