New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalise codebase with PHP 5.6 features #6166
Conversation
Hmm, I'd really like to see generators in action, especially in hydrators etc... 😉 |
Generators have the disadvantage of not being compatible with |
Patch seems good, but I'm reluctant to merge it due to all the merge conflicts it will cause. Also, |
@Ocramius I can work on the rebase on a different branch before the merge just to do a dry run |
@lcobucci it would also be fine to merge this only into |
@Ocramius I'll come with some suggestions after I get home 😉 |
Well, develop is 7.0+, how about also adding i.e. scalar typehints then? |
@Majkl578 can be done, but needs accurate migration documentation with every signature modification |
@Ocramius Of course, the real pain would be return types in interfaces I guess because of their variance (parameters are fine in terms of migration). |
If these modifications were done with some kind of script ( |
@Ocramius I've started to rebase develop (without these changes) and even with some broken tests I'm almost done. I've created this PR to have a better baseline for contributing to the ORM. My idea was to have it on I understand that it's a freaking huge amount of changes but I think that it needed to be done in order to keep our code standardised (as much as possible). |
@Ocramius we have All the conflicts were solved so there should be no concern regarding this now. Would be good if you and @guilhermeblanco could check and decide about this clean-up 😉. |
@lcobucci given that the rebase worked, this can be merged, thanks! |
Sorry for the HUGE pr here but IMO we need to do that so our contributors can have a better source for their tests (and we don't need to ask for these kind of stuff over and over again).