Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong DQL example #6212

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Fix wrong DQL example #6212

merged 1 commit into from
Jan 4, 2017

Conversation

malukenho
Copy link

Linking #1808

/cc @lcobucci

@lcobucci
Copy link
Member

lcobucci commented Jan 3, 2017 •
edited
Loading

@malukenho thanks but shouldn't master be the destination branch (develop is for v3)?

@lcobucci lcobucci self-assigned this Jan 3, 2017
@malukenho malukenho changed the base branch from develop to master January 3, 2017 23:39
@malukenho
Copy link
Author

@lcobucci done

lcobucci
lcobucci approved these changes Jan 4, 2017
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @malukenho

@lcobucci lcobucci merged commit c86865a into doctrine:master Jan 4, 2017
@lcobucci lcobucci mentioned this pull request Jan 4, 2017
Closed
@Ocramius Ocramius added this to the 2.6.0 milestone Jan 4, 2017
@malukenho malukenho deleted the hotfix/#1808-fix-sql-example branch January 4, 2017 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcobucci lcobucci lcobucci approved these changes

Assignees

@lcobucci lcobucci

Labels
Documentation
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malukenho @lcobucci @Ocramius